Merge branch 'master' into 'master'

# Conflicts:
#   Dockerfile
#   README.md
#   jupyter_c_kernel_pvcheck/kernel.py
#   setup.py

Dockerfile

@@ -21,4 +21,3 @@ RUN jupyter-kernelspec install jupyter_c_kernel_pvcheck/c_spec/
 RUN chmod 777 -R /home/jovyan/ 
 
 WORKDIR /home/$NB_USER/
-

README.md

@@ -55,4 +55,4 @@ If the code compiles and runs without errors, pvcheck is optionally run. Input a
 - Block the output diplay in case of massive amounts of lines written, i.e. in infinite loops, to avoid browser crashes √ USE EXT LIMIT_OUTPUT
 - Find a way to allow interactive input (through pty and select() maybe?)
 - Find a fix for the syntax highlighting not working on new cells √ REFRESH THE PAGE, this is something related to the javascript front-end
-- Manage extension
+- Manage extension
\ No newline at end of file

example-notebook.ipynb

+{
+ "cells": [
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "# Valid code"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 1,
+   "metadata": {
+    "collapsed": false
+   },
+   "outputs": [
+    {
+     "name": "stderr",
+     "output_type": "stream",
+     "text": []
+    },
+    {
+     "name": "stdout",
+     "output_type": "stream",
+     "text": [
+      "Hello world\n"
+     ]
+    }
+   ],
+   "source": [
+    "#include <stdio.h>\n",
+    "\n",
+    "int main() {\n",
+    "    printf(\"Hello world\\n\");\n",
+    "}"
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "But the kernel will also display compilations warnings and errors if we have some. Let's try to remove the `#include <stdio.h>` statement, which if necessary for `printf` to work."
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "# Code generating warnings during compilation"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 2,
+   "metadata": {
+    "collapsed": false
+   },
+   "outputs": [
+    {
+     "name": "stderr",
+     "output_type": "stream",
+     "text": [
+      "/var/folders/31/qct57s856n5f0b2r4tgbmn1c0000gn/T/tmp0Qan0v.c:2:5: warning: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Wimplicit-function-declaration]\n",
+      "    printf(\"Hello world\\n\");\n",
+      "    ^\n",
+      "/var/folders/31/qct57s856n5f0b2r4tgbmn1c0000gn/T/tmp0Qan0v.c:2:5: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'\n",
+      "1 warning generated.\n"
+     ]
+    },
+    {
+     "name": "stdout",
+     "output_type": "stream",
+     "text": [
+      "Hello world\n"
+     ]
+    }
+   ],
+   "source": [
+    "int main() {\n",
+    "    printf(\"Hello world\\n\");\n",
+    "}"
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "You can see that the warning are displayed, but the code is still executed."
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "# Code generating errors during compilation"
+   ]
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 3,
+   "metadata": {
+    "collapsed": false
+   },
+   "outputs": [
+    {
+     "name": "stderr",
+     "output_type": "stream",
+     "text": [
+      "/var/folders/31/qct57s856n5f0b2r4tgbmn1c0000gn/T/tmpw4Kz3c.c:2:5: warning: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Wimplicit-function-declaration]\n",
+      "    printf(\"Hello world\")\n",
+      "    ^\n",
+      "/var/folders/31/qct57s856n5f0b2r4tgbmn1c0000gn/T/tmpw4Kz3c.c:2:5: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'\n",
+      "/var/folders/31/qct57s856n5f0b2r4tgbmn1c0000gn/T/tmpw4Kz3c.c:2:26: error: expected ';' after expression\n",
+      "    printf(\"Hello world\")\n",
+      "                         ^\n",
+      "                         ;\n",
+      "1 warning and 1 error generated.\n",
+      "[C kernel] GCC exited with code 1, the executable will not be executed"
+     ]
+    },
+    {
+     "name": "stdout",
+     "output_type": "stream",
+     "text": []
+    }
+   ],
+   "source": [
+    "int main() {\n",
+    "    printf(\"Hello world\")\n",
+    "}"
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "metadata": {},
+   "source": [
+    "You can see that the errors and warnings are shown, but the code is not executed. The retcode is also added to the end of `stderr`"
+   ]
+  }
+ ],
+ "metadata": {
+  "kernelspec": {
+   "display_name": "C",
+   "language": "c",
+   "name": "c_kernel"
+  },
+  "language_info": {
+   "file_extension": "c",
+   "mimetype": "text/plain",
+   "name": "c"
+  }
+ },
+ "nbformat": 4,
+ "nbformat_minor": 0
+}

install.sh

+echo "   ___                   _              _____   _   __                     _ "
+echo "  |_  |                 | |            /  __ \ | | / /                    | |"
+echo "    | |_   _ _ __  _   _| |_ ___ _ __  | /  \/ | |/ /  ___ _ __ _ __   ___| |"
+echo "    | | | | | '_ \| | | | __/ _ \ '__| | |     |    \ / _ \ '__| '_ \ / _ \ |"
+echo "/\__/ / |_| | |_) | |_| | ||  __/ |    | \__/\ | |\  \  __/ |  | | | |  __/ |"
+echo "\____/ \__._| .__/ \__. |\__\___|_|     \____/ \_| \_/\___|_|  |_| |_|\___|_|"
+echo "            | |     __/ |                                                    "
+echo "            |_|    |___/                                                     "
+
+
+repository="https://rlabgw0.unipv.it/tutorato_jupyterhub/jupyter-c-kernel-pvcheck"
+repo_name="jupyter-c-kernel-pvcheck"
+
+set -x
+
+# echo ":: Installing python module C kernel."
+#pip install git+$repository; echo "Done. "
+cd /opt/
+echo ":: Cloning Jupyter C-kernel... "
+git clone $repository $repo_name; echo "Done. "
+
+echo ":: Installing python module C kernel."
+ls
+pip install -e ./$repo_name
+cd $repo_name
+echo ":: Installing kernel specification"
+jupyter-kernelspec install c_spec/ ; echo "Done."
+echo ":: Removing repository"
+
+echo "Completed! Installation successful. You can type jupyter-notebook and be happy"
+
+cd $OLDPWD
\ No newline at end of file

jupyter_c_kernel_pvcheck/kernel.py

@@ -412,4 +412,4 @@ class CKernel(Kernel):
 
     def do_shutdown(self, restart):
         """Cleanup the created source code files and executables when shutting down the kernel"""
-        self.cleanup_files()
+        self.cleanup_files()
\ No newline at end of file

setup.py

@@ -8,4 +8,4 @@ setup(name='jupyter_c_kernel_pvcheck',
       download_url='https://lstanzani@rlabgw0.unipv.it/lstanzani/jupyter-c-kernel-pvcheck/repository/archive.tar?ref=master',
       packages=['jupyter_c_kernel_pvcheck'],
       keywords=['jupyter', 'kernel', 'c', 'pvcheck']
-      )
+      )
\ No newline at end of file